hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14180) FileSystem contract tests to replace JUnit 3 with 4
Date Mon, 08 May 2017 09:56:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000528#comment-16000528
] 

Steve Loughran commented on HADOOP-14180:
-----------------------------------------

OK, this looks good, but the Azure tests are NPE-ing.

I suspect we'd have problems with the swift & s3 ones, but as they aren't being run by
Yetus, we aren't catching those. Whatever fixes Azure is what we (I?) will have to apply there.

Do you know why the Azure tests are failing? If we can address that then I'll apply this patch
locally and deal with the other blobstores

> FileSystem contract tests to replace JUnit 3 with 4
> ---------------------------------------------------
>
>                 Key: HADOOP-14180
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14180
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Mingliang Liu
>            Assignee: Xiaobing Zhou
>              Labels: test
>         Attachments: HADOOP-14180.000.patch
>
>
> This is from discussion in [HADOOP-14170], as Steve commented:
> {quote}
> ...it's time to move this to JUnit 4, annotate all tests with @test, and make the test
cases skip if they don't have the test FS defined. JUnit 3 doesn't support Assume, so when
I do test runs without the s3n or s3 fs specced, I get lots of errors I just ignore.
> ...Move to Junit 4, and, in our own code, find everywhere we've subclassed a method to
make the test a no-op, and insert an Assume.assumeTrue(false) in there so they skip properly.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message