hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14166) Reset the DecayRpcScheduler AvgResponseTime metric to zero when queue is not used
Date Mon, 22 May 2017 12:33:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019527#comment-16019527
] 

Hadoop QA commented on HADOOP-14166:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 24s{color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m  3s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m 49s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 34s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  6s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 21s{color}
| {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 23s{color} | {color:red}
hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 48s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 38s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m 31s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 14m 31s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 36s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 11s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 19s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 49s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 52s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  9m 29s{color} | {color:green}
hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 34s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 64m 15s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-14166 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12857078/HADOOP-14166.001.patch
|
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  findbugs
 checkstyle  |
| uname | Linux f7dcbd7b9048 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / b6f66b0 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| findbugs | https://builds.apache.org/job/PreCommit-HADOOP-Build/12370/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
|
|  Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/12370/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
|
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/12370/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Reset the DecayRpcScheduler AvgResponseTime metric to zero when queue is not used
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-14166
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14166
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: common
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>         Attachments: HADOOP-14166.001.patch
>
>
> {noformat}
>  "name" : "Hadoop:service=NameNode,name=DecayRpcSchedulerMetrics2.ipc.8020",
>     "modelerType" : "DecayRpcSchedulerMetrics2.ipc.8020",
>     "tag.Context" : "ipc.8020",
>     "tag.Hostname" : "host1",
>     "DecayedCallVolume" : 3,
>     "UniqueCallers" : 1,
>     "Caller(root).Volume" : 266,
>     "Caller(root).Priority" : 3,
>     "Priority.0.AvgResponseTime" : 6.151201023385511E-5,
>     "Priority.1.AvgResponseTime" : 0.0,
>     "Priority.2.AvgResponseTime" : 0.0,
>     "Priority.3.AvgResponseTime" : 1.184686336544601,
>     "Priority.0.CompletedCallVolume" : 0,
>     "Priority.1.CompletedCallVolume" : 0,
>     "Priority.2.CompletedCallVolume" : 0,
>     "Priority.3.CompletedCallVolume" : 2,
>     "CallVolume" : 266
> {noformat}
> "Priority.0.AvgResponseTime" is always "6.151201023385511E-5" even the queue is not used
for long time.
> {code}
>       if (lastAvg > PRECISION || averageResponseTime > PRECISION) {
>         if (enableDecay) {
>           final double decayed = decayFactor * lastAvg + averageResponseTime;
>           LOG.info("Decayed "  + i + " time " +   decayed);
>           responseTimeAvgInLastWindow.set(i, decayed);
>         } else {
>           responseTimeAvgInLastWindow.set(i, averageResponseTime);
>         }
>       }
> {code}
> we should reset it to zero when above condition is false.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message