hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11869) Suppress ParameterNumber checkstyle violations for overridden methods
Date Thu, 18 May 2017 01:36:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015054#comment-16015054
] 

Chris Douglas commented on HADOOP-11869:
----------------------------------------

Submitting [~jeagles] patch. A two-year old JIRA crossed with other, subsequent fixes is too
hard to track. If this is worth committing, let's push it. If there's still checkstyle tuning
to be done, let's pick it up in another ticket.

> Suppress ParameterNumber checkstyle violations for overridden methods
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-11869
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11869
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Sidharta Seethana
>            Assignee: Jonathan Eagles
>         Attachments: HADOOP-11869.ParameterNumber.patch
>
>
> There seem to be a lot of arcane errors being caused by the checkstyle rules/script.
Real issues tend to be buried in this noise. Some examples :
> 1. "Line is longer than 80 characters" - this shows up even for cases like import statements,
package names
> 2. "Missing a Javadoc comment." - for every private member including cases like "Configuration
conf". 
> Having rules like these will result in a large number of pre-commit job failures. We
should fine tune the rules used for checkstyle. 
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message