Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 04191200C70 for ; Thu, 20 Apr 2017 01:57:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 02A38160BAD; Wed, 19 Apr 2017 23:57:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4B85B160B9C for ; Thu, 20 Apr 2017 01:57:07 +0200 (CEST) Received: (qmail 48065 invoked by uid 500); 19 Apr 2017 23:57:06 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 48054 invoked by uid 99); 19 Apr 2017 23:57:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Apr 2017 23:57:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 10C1E1A0763 for ; Wed, 19 Apr 2017 23:57:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.001 X-Spam-Level: X-Spam-Status: No, score=-100.001 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id D007PzD3FYFU for ; Wed, 19 Apr 2017 23:57:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1109F5FC96 for ; Wed, 19 Apr 2017 23:57:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 72551E06BE for ; Wed, 19 Apr 2017 23:57:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1D90B21B54 for ; Wed, 19 Apr 2017 23:57:04 +0000 (UTC) Date: Wed, 19 Apr 2017 23:57:04 +0000 (UTC) From: "Chen Liang (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-14329) Thread leakage in Hadoop RollingAverages metric collection MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 19 Apr 2017 23:57:08 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen Liang updated HADOOP-14329: -------------------------------- Attachment: HADOOP-14329.001.patch Post v001 patch to shut down these executors. All [~xyao] mentioned have been addressed, except for {{DiskBalancer#scheduler}} which I think is eventually shut down in {{DiskBalancer#shudwon()}} and {{DiskBalancer#shutdownExecutor}}. > Thread leakage in Hadoop RollingAverages metric collection > ---------------------------------------------------------- > > Key: HADOOP-14329 > URL: https://issues.apache.org/jira/browse/HADOOP-14329 > Project: Hadoop Common > Issue Type: Bug > Components: metrics > Affects Versions: 3.0.0-alpha2 > Reporter: Hrishikesh Gadre > Assignee: Chen Liang > Priority: Minor > Labels: newbie > Attachments: HADOOP-14329.001.patch > > > The rolling averages metric implementation defines a static ScheduledExecutorService instance which is not shutdown properly. This results in leaking the corresponding thread. This issue was identified while testing Solr/Hadoop 3 integration. > Here is the relevant portion of the code involved, > https://github.com/apache/hadoop/blob/c1549352cf1d1b1b45d7b613f993d45649b8efcf/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/RollingAverages.java#L65 -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org