hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14338) Fix warnings from Spotbugs in hadoop-yarn
Date Mon, 24 Apr 2017 06:36:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980760#comment-15980760
] 

Naganarasimha G R commented on HADOOP-14338:
--------------------------------------------

Thanks [~cheersyang] for looking more into it. Can we discuss this further in YARN-6515 itself
as we have almost concluded on per project split ? 

bq.  If we set a default value to /sys/fs/cgroups and use that as default. If user sets yarn.nodemanager.linux-container-executor.cgroups.mount
without explicitly setting yarn.nodemanager.linux-container-executor.cgroups.mount-path, it
will mount cgroups to /sys/fs/cgroups no matter what under neath linux distribution is, would
that cause problems? Looks like we need a check here. What do you think?
Actually i was skeptical when i made the change in the YARN-6515 patch, IIUC we need to keep
the code in sync with CgroupsHandler, there if {{yarn.nodemanager.linux-container-executor.cgroups.mount}}
is true its assumed that {{yarn.nodemanager.linux-container-executor.cgroups.mount-path}}
is configured. if {{yarn.nodemanager.linux-container-executor.cgroups.mount}} is false they
read it from mtab. 
Hence i wanted to discuss further on this with Sidhart seethana.

May be we can move these comments to YARN-6515 itself so that we can get focused reviews.

> Fix warnings from Spotbugs in hadoop-yarn
> -----------------------------------------
>
>                 Key: HADOOP-14338
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14338
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: HADOOP-14338.001.patch, HADOOP-14338.002.patch, HADOOP-14338.003.patch,
HADOOP-14338.004.patch, HADOOP-14338.005.patch
>
>
> Fix warnings from Spotbugs in hadoop-yarn since switched from findbugs to spotbugs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message