hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14333) New exception thrown by (private) DFSClient API isHDFSEncryptionEnabled broke hacky hive code
Date Fri, 21 Apr 2017 13:24:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978721#comment-15978721
] 

Daryn Sharp commented on HADOOP-14333:
--------------------------------------

Quiet bothered by hive using private hdfs apis with the added touch of reflection.  It's one
thing to hack your own project because when you break it you fix it, but completely different
to hack another project...  There should be a followup jira to remove the method to ensure
hive makes the change.

+1 After adding @Deprecated to the method and moving this jira to the hdfs project.

> New exception thrown by (private) DFSClient API isHDFSEncryptionEnabled broke hacky hive
code 
> ----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-14333
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14333
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.8.1, 3.0.0-alpha3
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-14333.001.patch, HADOOP-14333.002.patch, HADOOP-14333.003.patch
>
>
> Though Hive should be fixed not to access DFSClient which is private to HADOOP, removing
the throws added by HADOOP-14104 is a quicker solution to unblock hive.
> Hive code
> {code}
> private boolean isEncryptionEnabled(DFSClient client, Configuration conf) {
>   try {
>     DFSClient.class.getMethod("isHDFSEncryptionEnabled");
>   } catch (NoSuchMethodException e) {
>     // the method is available since Hadoop-2.7.1
>     // if we run with an older Hadoop, check this ourselves
>     return !conf.getTrimmed(DFSConfigKeys.DFS_ENCRYPTION_KEY_PROVIDER_URI, "").isEmpty();
>   }
>   return client.isHDFSEncryptionEnabled();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message