hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-14329) Thread leakage in Hadoop RollingAverages metric collection
Date Wed, 19 Apr 2017 23:21:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975716#comment-15975716
] 

Xiaoyu Yao edited comment on HADOOP-14329 at 4/19/17 11:20 PM:
---------------------------------------------------------------

Good catch, [~hgadre]. I did a quick search and find similar leaking issue exist in other
executors as well. 
The {{MutableQuantiles}} has broader usages in current code base than the newly introduced
{{RollingAverages#scheduler}}. 

{code}
MutableQuantiles#scheduler
ZKFailoverController#delayExecutor
{code}


was (Author: xyao):
Good catch, [~hgadre]. I did a quick search and find similar leaking issue exist in other
executors as well. 
The {{MutableQuantiles}} has broader usages in current code base than the newly introduced
{{RollingAverages#scheduler}}. 
I assigned it to [~xiaobingo] to fix them all.

{code}
MutableQuantiles#scheduler
ZKFailoverController#delayExecutor
{code}

> Thread leakage in Hadoop RollingAverages metric collection
> ----------------------------------------------------------
>
>                 Key: HADOOP-14329
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14329
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Hrishikesh Gadre
>            Assignee: Chen Liang
>            Priority: Minor
>              Labels: newbie
>
> The rolling averages metric implementation defines a static ScheduledExecutorService
instance which is not shutdown properly. This results in leaking the corresponding thread.
This issue was identified while testing Solr/Hadoop 3 integration.
> Here is the relevant portion of the code involved,
> https://github.com/apache/hadoop/blob/c1549352cf1d1b1b45d7b613f993d45649b8efcf/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/RollingAverages.java#L65



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message