hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14324) Switch to fs.s3a.server-side-encryption.key as property for encryption secret; improve error reporting and diagnostics
Date Thu, 20 Apr 2017 21:34:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977579#comment-15977579
] 

John Zhuge commented on HADOOP-14324:
-------------------------------------

+1  Patch 003 LGTM with a nit:

TestConfigRedcator.java:67-68:  Move them to where the existing "fs.s3a" lines are?

> Switch to fs.s3a.server-side-encryption.key as property for encryption secret; improve
error reporting and diagnostics
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-14324
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14324
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.9.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Blocker
>         Attachments: HADOOP-14324-branch-2-001.patch, HADOOP-14324-branch-2-002.patch,
HADOOP-14324-branch-2-003.patch
>
>
> Before this ships, can we rename {{fs.s3a.server-side-encryption-key}} to {{fs.s3a.server-side-encryption.key}}.
> This makes it consistent with all other .key secrets in S3A. so
> * simplifies documentation
> * reduces confusion "is it a - or a ."? This confusion is going to surface in config
and support
> I know that CDH is shipping with the old key, but it'll be easy for them to add a deprecation
property to handle the migration. I do at least what the ASF release to be stable before it
ships.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message