hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damien Claveau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14300) GraphiteSink reports metrics containing undesirable whitespaces
Date Thu, 13 Apr 2017 09:13:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967325#comment-15967325
] 

Damien Claveau commented on HADOOP-14300:
-----------------------------------------

A couple of things :
1. There is already a unit test class named org.apache.hadoop.metrics2.impl.TestGraphiteMetrics
Can I enrich it with my test, or should I rename it TestGraphiteSink to conform to the naming
rules, or should I add a new class TestGraphiteSink ?

2. I think I will have 2 more Jira to open to fully achieve the GraphiteSink. 
The first one is a feature addition to filter out tags from the metric prefix string.
That would be useful to avoid the situation I have with the tag "StorageInfo".
I will propose it like in https://issues.apache.org/jira/browse/HADOOP-7507

The second one will be a fix for the regression described here https://issues.apache.org/jira/browse/HADOOP-11400?focusedCommentId=14977496&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14977496

Any general advice before I start that work ?

> GraphiteSink reports metrics containing undesirable whitespaces
> ---------------------------------------------------------------
>
>                 Key: HADOOP-14300
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14300
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.7.1, 2.7.2, 2.7.3
>            Reporter: Damien Claveau
>            Priority: Trivial
>         Attachments: HADOOP-14300
>
>
> According to the Graphite documentation, the data sent must be in the following format:
<metric path> <metric value> <metric timestamp>
> But some tag values that are flattened in the metricpath string sometimes include whitespaces
and violate the carbon/graphite format.
> For example, the dirpath enumeration from the datanode : 
> FSDatasetState.org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.Context=FSDatasetState.StorageInfo=FSDataset{dirpath='[/data/1/hdfs/data/current,
/data/2/hdfs/data/current]'}.Hostname=worker1.Capacity 78436466688 1491986609
> Currently, none of the aggregators available in the Graphite ecosystem can handle these
malformed metrics. These whitespaces should be replaced by underscores.
> I will be happy to attach a small patch.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message