hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14284) Shade Guava everywhere
Date Fri, 07 Apr 2017 20:32:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961392#comment-15961392
] 

Sean Busbey commented on HADOOP-14284:
--------------------------------------

I presume we end up using our project wide LICENSE/NOTICE in this jar?

{code}
53	      <plugin>
54	        <groupId>org.apache.maven.plugins</groupId>
55	        <artifactId>maven-shade-plugin</artifactId>
56	        <executions>
57	          <execution>
58	            <goals>
59	              <goal>shade</goal>
60	            </goals>
61	            <phase>package</phase>
62	            <configuration>
63	              <createDependencyReducedPom>false</createDependencyReducedPom>
64	              <relocations>
{code}

Don't we need to have a dependency reduced pom in order to avoid having Guava show up as a
transitive dependency?

{code}

75	              <filters>
76	                <filter>
77	                  <artifact>com.google.guava:guava</artifact>
78	                  <excludes>
79	                    <exclude>META-INF/**</exclude>
80	                  </excludes>
81	                </filter>
82	              </filters>
{code}

What are we trying to exclude here? I don't see much of consequence in the guava jar.

> Shade Guava everywhere
> ----------------------
>
>                 Key: HADOOP-14284
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14284
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Andrew Wang
>            Priority: Blocker
>         Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts. Unfortunately, these
projects also consume our private artifacts like {{hadoop-hdfs}}. They also are unlikely on
the new shaded client introduced by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams. This isn't
a requirement for all dependency upgrades, but it's necessary for known-bad dependencies like
Guava.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message