hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Badger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14277) TestTrash.testTrashRestarts is flaky
Date Mon, 17 Apr 2017 13:39:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971066#comment-15971066
] 

Eric Badger commented on HADOOP-14277:
--------------------------------------

{noformat}
+          GenericTestUtils.waitFor(new Supplier<Boolean>() {
+            @Override public Boolean get() {
+              return countdownEmptier.getCountLeft()
+                  == currentCount;
+            }
+          }, 10, 50);
{noformat}
50ms is much too small for a timeout here. I'd bump it up to something like 5 seconds. 

{noformat}
          } catch (IOException e) {
            // Expect no exception from deleting a checkpoint.
{noformat}
While we may not expect an exception, we can at least log one if it were to happen. Otherwise
we're completely in the dark if the delete functionality changes and sometimes does throw.

The verifyCountdownEmptier thread and the emptier thread that's created inside of it are not
properly synchronized. This leads to a test failure due to timeout exception ~1/6 of the time
on my machine. At a glance, not sure what's causing this, but it's certainly an issue. 

> TestTrash.testTrashRestarts is flaky
> ------------------------------------
>
>                 Key: HADOOP-14277
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14277
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Eric Badger
>            Assignee: Weiwei Yang
>         Attachments: HADOOP-14277.001.patch, HADOOP-14277.002.patch, HADOOP-14277.003.patch
>
>
> {noformat}
> junit.framework.AssertionFailedError: Expected num of checkpoints is 2, but actual is
3 expected:<2> but was:<3>
> 	at junit.framework.Assert.fail(Assert.java:57)
> 	at junit.framework.Assert.failNotEquals(Assert.java:329)
> 	at junit.framework.Assert.assertEquals(Assert.java:78)
> 	at junit.framework.Assert.assertEquals(Assert.java:234)
> 	at junit.framework.TestCase.assertEquals(TestCase.java:401)
> 	at org.apache.hadoop.fs.TestTrash.verifyAuditableTrashEmptier(TestTrash.java:892)
> 	at org.apache.hadoop.fs.TestTrash.testTrashRestarts(TestTrash.java:593)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message