hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14233) Delay construction of PreCondition.check failure message in Configuration#set
Date Mon, 24 Apr 2017 15:30:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981359#comment-15981359
] 

Jonathan Eagles commented on HADOOP-14233:
------------------------------------------

Good catch on the commit message. Let me know if you want me to perform the corrective revert-and-reapply.

> Delay construction of PreCondition.check failure message in Configuration#set
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-14233
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14233
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>             Fix For: 2.9.0, 2.8.1, 3.0.0-alpha3
>
>         Attachments: HADOOP-14233.1.patch
>
>
> The String in the precondition check is constructed prior to failure detection. Since
the normal case is no error, we can gain performance by delaying the construction of the string
until the failure is detected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message