hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13363) Upgrade protobuf from 2.5.0 to something newer
Date Thu, 06 Apr 2017 04:04:42 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958253#comment-15958253
] 

stack commented on HADOOP-13363:
--------------------------------

[~kihwal] Good point.

What we thinking for a shading approach?

Shading runs post package and pulls in the relocated classes into the jar that references
them.

I see hadoop common, hdfs, hdfs-client, mr-client, yarn-common, yarn-client, yarn-server all
making reference to pb (I didn't look at src/test). We thinking we'd dupe instances of pb
jars up into each of these artifacts.

Would it make sense having a shaded-3rdparty-libs jar that had relocated protobuf and other
libs we want to shade? Downside is all pb references would have to be changed to reference
the relocated classes (org.apache.hadoop.com.google.protobuf.*).

Would hadoop3 ship a pb2.5 at all?

> Upgrade protobuf from 2.5.0 to something newer
> ----------------------------------------------
>
>                 Key: HADOOP-13363
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13363
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0-alpha1, 3.0.0-alpha2
>            Reporter: Allen Wittenauer
>            Priority: Blocker
>         Attachments: HADOOP-13363.001.patch, HADOOP-13363.002.patch, HADOOP-13363.003.patch,
HADOOP-13363.004.patch, HADOOP-13363.005.patch
>
>
> Standard protobuf 2.5.0 does not work properly on many platforms.  (See, for example,
https://gist.github.com/BennettSmith/7111094 ).  In order for us to avoid crazy work arounds
in the build environment and the fact that 2.5.0 is starting to slowly disappear as a standard
install-able package for even Linux/x86, we need to either upgrade or self bundle or something
else.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message