Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9154A200C2B for ; Thu, 2 Mar 2017 17:39:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 90189160B6A; Thu, 2 Mar 2017 16:39:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8F2A160B6F for ; Thu, 2 Mar 2017 17:39:49 +0100 (CET) Received: (qmail 17072 invoked by uid 500); 2 Mar 2017 16:39:49 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 17061 invoked by uid 99); 2 Mar 2017 16:39:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Mar 2017 16:39:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6E9F1C01DC for ; Thu, 2 Mar 2017 16:39:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id b7RxQJ7uEubw for ; Thu, 2 Mar 2017 16:39:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 772635F257 for ; Thu, 2 Mar 2017 16:39:47 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 46DCBE0A4B for ; Thu, 2 Mar 2017 16:39:46 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9C3BF24178 for ; Thu, 2 Mar 2017 16:39:45 +0000 (UTC) Date: Thu, 2 Mar 2017 16:39:45 +0000 (UTC) From: "Jason Lowe (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-14138) Remove S3A ref from META-INF service discovery, rely on existing core-default entry MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 02 Mar 2017 16:39:50 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892569#comment-15892569 ] Jason Lowe commented on HADOOP-14138: ------------------------------------- +1 patch looks good to me. I agree that this would be a good candidate for 2.8 and 2.7 Will commit this tomorrow if there are no objections. Curious why the patch wasn't against trunk instead of branch-2. Is there a reason this shouldn't go into trunk? It applies (mostly) cleanly there, and I see the fs.s3a.impl property is still in core-default there. > Remove S3A ref from META-INF service discovery, rely on existing core-default entry > ----------------------------------------------------------------------------------- > > Key: HADOOP-14138 > URL: https://issues.apache.org/jira/browse/HADOOP-14138 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 2.9.0 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Critical > Attachments: HADOOP-14138-branch-2-001.patch > > > As discussed in HADOOP-14132, the shaded AWS library is killing performance starting all hadoop operations, due to classloading on FS service discovery. > This is despite the fact that there is an entry for fs.s3a.impl in core-default.xml, *we don't need service discovery here* > Proposed: > # cut the entry from {/hadoop-aws/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem}} > # when HADOOP-14132 is in, move to that, including declaring an XML file exclusively for s3a entries > I want this one in first as its a major performance regression, and one we coula actually backport to 2.7.x, just to improve load time slightly there too -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org