Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 32246200C28 for ; Mon, 13 Mar 2017 21:18:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 30D4C160B85; Mon, 13 Mar 2017 20:18:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7AEA3160B5D for ; Mon, 13 Mar 2017 21:18:51 +0100 (CET) Received: (qmail 86109 invoked by uid 500); 13 Mar 2017 20:18:50 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 86068 invoked by uid 99); 13 Mar 2017 20:18:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 20:18:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B35541A0402 for ; Mon, 13 Mar 2017 20:18:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id XkHRyrjy4lCU for ; Mon, 13 Mar 2017 20:18:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4B6C55FDD9 for ; Mon, 13 Mar 2017 20:18:47 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D0FC2E0419 for ; Mon, 13 Mar 2017 20:18:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2E914243C6 for ; Mon, 13 Mar 2017 20:18:42 +0000 (UTC) Date: Mon, 13 Mar 2017 20:18:42 +0000 (UTC) From: "Andrew Wang (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-14135) Remove URI parameter in AWSCredentialProvider constructors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Mar 2017 20:18:52 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang updated HADOOP-14135: --------------------------------- Target Version/s: 2.9.0, 3.0.0-alpha3 (was: 2.8.0, 3.0.0-alpha2) > Remove URI parameter in AWSCredentialProvider constructors > ---------------------------------------------------------- > > Key: HADOOP-14135 > URL: https://issues.apache.org/jira/browse/HADOOP-14135 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HADOOP-14135.000.patch, HADOOP-14135.001.patch, HADOOP-14135.002.patch, HADOOP-14135.003.patch > > > This was from comment in [HADOOP-13252]. > It looks like the URI parameter is not needed for our AWSCredentialProvider constructors. This was useful because we relied on URI parameter for retrieving user:pass. Now in binding URIs, we have > {code} > 279 S3xLoginHelper.Login creds = getAWSAccessKeys(binding, conf); > 280 credentials.add(new BasicAWSCredentialsProvider( > 281 creds.getUser(), creds.getPassword())); > {code} > This way, we only need configuration object (if necessary) for all AWSCredentialProvider implementations. The benefit is that, if we create AWSCredentialProvider list for DynamoDB, we don't have to pass down the associated file system URI. This might be useful to S3Guard tools. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org