Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 96EE8200C38 for ; Wed, 1 Mar 2017 01:23:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 95AC1160B81; Wed, 1 Mar 2017 00:23:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DE843160B7C for ; Wed, 1 Mar 2017 01:23:48 +0100 (CET) Received: (qmail 90908 invoked by uid 500); 1 Mar 2017 00:23:48 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 90896 invoked by uid 99); 1 Mar 2017 00:23:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2017 00:23:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 789B9182765 for ; Wed, 1 Mar 2017 00:23:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.547 X-Spam-Level: X-Spam-Status: No, score=-1.547 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-2.999, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id x3HYP14y6SZL for ; Wed, 1 Mar 2017 00:23:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5186E5F23A for ; Wed, 1 Mar 2017 00:23:46 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C31D4E0600 for ; Wed, 1 Mar 2017 00:23:45 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 817992415C for ; Wed, 1 Mar 2017 00:23:45 +0000 (UTC) Date: Wed, 1 Mar 2017 00:23:45 +0000 (UTC) From: "Aaron Fabbri (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HADOOP-14130) Simplify DynamoDBClientFactory for creating Amazon DynamoDB clients MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 01 Mar 2017 00:23:49 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889189#comment-15889189 ] Aaron Fabbri edited comment on HADOOP-14130 at 3/1/17 12:22 AM: ---------------------------------------------------------------- Thanks for the explanation [~liuml07]. If I understand correctly, the new API requires region as well, when you specify endpoint? I wanted to remove endpoint before but didn't want to break the DDBLocal tests. Are we going to abandon the DDBLocal tests and just use ITests against real DDB? If that is the case, I'll +1 this. I preferred to keep endpoint but won't block this if you guys want it. Thanks for clarifying. was (Author: fabbri): Thanks for the explanation [~liuml07]. If I understand correctly, the new API requires region as well, when you specify endpoint? I wanted to remove endpoint before but didn't want to break the DDBLocal tests. Are we going to abandon the DDBLocal tests and just use ITests against real DDB? If that is the case, I'll +1 this. I preferred to keep region but won't block this if you guys want it. Thanks for clarifying. > Simplify DynamoDBClientFactory for creating Amazon DynamoDB clients > ------------------------------------------------------------------- > > Key: HADOOP-14130 > URL: https://issues.apache.org/jira/browse/HADOOP-14130 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Reporter: Mingliang Liu > Assignee: Mingliang Liu > Attachments: HADOOP-14130-HADOOP-13345.000.patch, HADOOP-14130-HADOOP-13345.001.patch > > > So, we are using deprecated {{AmazonDynamoDBClient}} class to create a DynamoDB client instead of the recommended builder. We had discussion in [HADOOP-14090] for preferring region to endpoints for user to specify the DynamoDB region (if associated S3 region is unknown or different). We have reported inconsistent behavior if endpoint and S3 region are different in [HADOOP-14027]. We also noticed that {{DynamoDBMetadataStore}} may sometimes logs nonsense region. And in [HADOOP-13252], we also have feelings that file system URI is not needed to create a {{AWSCredentialProvider}}. Resultantly we don't need to pass down file system URI for creating a DynamoDB client. > So this JIRA is to change this, best effort. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org