hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-14255) S3A to delete unnecessary fake directory objects in mkdirs()
Date Thu, 30 Mar 2017 20:27:41 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-14255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Mingliang Liu updated HADOOP-14255:
    Attachment: HADOOP-14255.000.patch

Tested against us-west-1 region.

$ mvn -Dit.test='ITestS3A*' -Dtest=none -Dscale -q clean verify

Results :

Tests run: 347, Failures: 0, Errors: 0, Skipped: 12

> S3A to delete unnecessary fake directory objects in mkdirs()
> ------------------------------------------------------------
>                 Key: HADOOP-14255
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14255
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HADOOP-14255.000.patch
> In S3AFileSystem, as an optimization, we delete unnecessary fake directory objects if
that directory contains at least one (nested) file. That is done in closing stream of newly
created file. However, if the directory becomes non-empty after we just create an empty subdirectory,
we do not delete its fake directory object though that fake directory object becomes "unnecessary".
> So in {{S3AFileSystem::mkdirs()}}, we have a pending TODO:
> {quote}
>   // TODO: If we have created an empty file at /foo/bar and we then call
>   // mkdirs for /foo/bar/baz/roo what happens to the empty file /foo/bar/?
>   private boolean innerMkdirs(Path p, FsPermission permission)
> {quote}
> This JIRA is to fix the TODO: provide consistent behavior for a fake directory object
between its nested subdirectory and nested file by deleting it.
> See related discussion in [HADOOP-14236]. Thanks [~stevel@apache.org] for discussion.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message