hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Krogen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14211) FilterFs and ChRootedFs are too aggressive about enforcing "authorityNeeded"
Date Fri, 24 Mar 2017 18:18:42 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940857#comment-15940857
] 

Erik Krogen commented on HADOOP-14211:
--------------------------------------

[~andrew.wang] thanks for the review/commit! Yeah, I checked, and they don't. The validation
logic generally became a little stricter in the {{FileContext}} APIs. Agreed that nothing
else really uses them which is, I assume, why I'm uncovering issues that only exist in the
"new" APIs and have been fixed in {{FileSystem}}...

> FilterFs and ChRootedFs are too aggressive about enforcing "authorityNeeded"
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-14211
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14211
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: viewfs
>    Affects Versions: 2.6.0
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>             Fix For: 2.9.0, 3.0.0-alpha3
>
>         Attachments: HADOOP-14211.000.patch, HADOOP-14211.001.patch
>
>
> Right now {{FilterFs}} and {{ChRootedFs}} pass the following up to the {{AbstractFileSystem}}
superconstructor:
> {code}
>     super(fs.getUri(), fs.getUri().getScheme(),
>         fs.getUri().getAuthority() != null, fs.getUriDefaultPort());
> {code}
> This passes a value of {{authorityNeeded==true}} for any {{fs}} which has an authority,
but this isn't necessarily the case - ViewFS is an example of this. You will encounter this
issue if you try to filter a ViewFS, or nest one ViewFS within another. The {{authorityNeeded}}
check isn't necessary in this case anyway; {{fs}} is already an instantiated {{AbstractFileSystem}}
which means it has already used the same constructor with the value of {{authorityNeeded}}
(and corresponding validation) that it actually requires.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message