hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14180) FileSystem contract tests to replace JUnit 3 with 4
Date Wed, 15 Mar 2017 20:48:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926963#comment-15926963
] 

Mingliang Liu commented on HADOOP-14180:
----------------------------------------

To make this task clear, we need to:
# Make {{FileSystemContractBaseTest}} not extend TestCase class
# Annotate all the test methods in {{FileSystemContractBaseTest}} and all its subclasses (~13)
{{@Test}}
# Add default timeout / exception Rules in the base class
# There are a few places that uses {{if (!renameSupported()) return;}} to skip FS that does
not support rename. Let's use {{assumeTrue(renameSupported()}} instead. This will be reflected
in test report, not just passing.
# There are a few places that uses {{if (!rootDirTestEnabled() return;}}. Let's assume as
well.
# Update javadoc if necessary

[~stevel@apache.org] please add more if I missed something.

> FileSystem contract tests to replace JUnit 3 with 4
> ---------------------------------------------------
>
>                 Key: HADOOP-14180
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14180
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Mingliang Liu
>            Assignee: Xiaobing Zhou
>
> This is from discussion in [HADOOP-14170], as Steve commented:
> {quote}
> ...it's time to move this to JUnit 4, annotate all tests with @test, and make the test
cases skip if they don't have the test FS defined. JUnit 3 doesn't support Assume, so when
I do test runs without the s3n or s3 fs specced, I get lots of errors I just ignore.
> ...Move to Junit 4, and, in our own code, find everywhere we've subclassed a method to
make the test a no-op, and insert an Assume.assumeTrue(false) in there so they skip properly.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message