hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-14178) Move Mockito up to version 2.x
Date Tue, 14 Mar 2017 11:08:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923990#comment-15923990
] 

Steve Loughran edited comment on HADOOP-14178 at 3/14/17 11:07 AM:
-------------------------------------------------------------------

Anuj, I would advise you to tread carefully with this one, as it's a bigger patch than it
looks

* updating POMs have dramatic consequences downstream
* if the imports change, it will span more of the code
* If it finds bugs in tests, the tests need to be changed, which means that the patch will
need to work out the real intent of the test, otherwise the fix could actually hide problems.

I think we'd be scared of any big patch for this. A small one, fine. But big: it'll span the
hadoop modules, need review, and so likely to stutter along.



was (Author: stevel@apache.org):
Anuj, I would advise you to tread carefully with this one, as it's a bigger patch than it
looks

* updating POMs have dramatic consequences downstream
* if the imports change, it will span more of the code
* which scares people

> Move Mockito up to version 2.x
> ------------------------------
>
>                 Key: HADOOP-14178
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14178
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 2.9.0
>            Reporter: Steve Loughran
>            Priority: Minor
>
> I don't know when Hadoop picked up Mockito, but it has been frozen at 1.8.5 since the
switch to maven in 2011. 
> Mockito is now at version 2.1, [with lots of Java 8 support|https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2].
That' s not just defining actions as closures, but in supporting Optional types, mocking methods
in interfaces, etc. 
> It's only used for testing, and, *provided there aren't regressions*, cost of upgrade
is low. The good news: test tools usually come with good test coverage. The bad: mockito does
go deep into java bytecodes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message