hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14135) Remove URI parameter in AWSCredentialProvider constructors
Date Fri, 03 Mar 2017 22:04:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895103#comment-15895103
] 

Mingliang Liu commented on HADOOP-14135:
----------------------------------------

Thanks [~mackrorysd] for your review.

Yes it will definitely conflicts with HADOOP-13345 branch. Fortunately that conflict is not
major as in HADOOP-13345 we only moved the code to a separate class/methods, not refactoring
too much S3Client factory. I locally cherry-picked to S3Guard branch and ran the integration
tests. Only [HADOOP-14129] and [HADOOP-14036] failed.
{code}
$ cmvn -Dit.test='ITestS3A*' -Dtest=none -Dscale -Ds3guard -Ddynamo -q clean verify

Results :

Tests in error:
  ITestS3ACredentialsInURL.testInstantiateFromURL:86 » InterruptedIO initTable: ...
  ITestS3AFileSystemContract>FileSystemContractBaseTest.testRenameToDirWithSamePrefixAllowed:669->FileSystemContractBaseTest.rename:525
» AWSServiceIO

Tests run: 348, Failures: 0, Errors: 2, Skipped: 14
{code}

> Remove URI parameter in AWSCredentialProvider constructors
> ----------------------------------------------------------
>
>                 Key: HADOOP-14135
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14135
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HADOOP-14135.000.patch, HADOOP-14135.001.patch, HADOOP-14135.002.patch,
HADOOP-14135.003.patch
>
>
> This was from comment in [HADOOP-13252].
> It looks like the URI parameter is not needed for our AWSCredentialProvider constructors.
This was useful because we relied on URI parameter for retrieving user:pass. Now in binding
URIs, we have
> {code}
> 279 S3xLoginHelper.Login creds = getAWSAccessKeys(binding, conf);
> 280	      credentials.add(new BasicAWSCredentialsProvider(
> 281	              creds.getUser(), creds.getPassword()));
> {code}
> This way, we only need configuration object (if necessary) for all AWSCredentialProvider
implementations. The benefit is that, if we create AWSCredentialProvider list for DynamoDB,
we don't have to pass down the associated file system URI. This might be useful to S3Guard
tools.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message