hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14120) needless S3AFileSystem.setOptionalPutRequestParameters in S3ABlockOutputStream putObject()
Date Thu, 23 Mar 2017 12:40:42 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938204#comment-15938204
] 

Steve Loughran commented on HADOOP-14120:
-----------------------------------------

sorry, not got back to you on this.

bq. Triggering s3 test cases in local env seems to need some configurations and s3 account,
right?

afraid so: here's our current policy: https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/testing.md

Jenkins can't run the tests (credential security), and for anyone working in this module should
be running their own tests during coding anyway. Hence: submitters need to do their local
test runs. We hare that harsh to everyone, even each other.

this is a one line patch; review is straightforward and I'll just run the tests locally to
see that all is well. But this is a special case: normally the requirement is "you'll need
to test locally and state which endpoint you worked with"

Anyway, tests in progress...

> needless S3AFileSystem.setOptionalPutRequestParameters in S3ABlockOutputStream putObject()
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-14120
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14120
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.9.0
>            Reporter: Steve Loughran
>            Assignee: Yuanbo Liu
>            Priority: Minor
>         Attachments: HADOOP-14120.001.patch
>
>
> There's a call to {{S3AFileSystem.setOptionalPutRequestParameters()}} in {{ S3ABlockOutputStream
putObject()}}
> The put request has already been created by the FS; this call is only superflous and
potentially confusing.
> Proposed: cut it, make the {{setOptionalPutRequestParameters()}} method private.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message