hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14094) Rethink S3GuardTool options
Date Fri, 03 Mar 2017 01:46:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893553#comment-15893553
] 

Mingliang Liu commented on HADOOP-14094:
----------------------------------------

The v4 patch looks good to me overall.

I'm wondering should we use the {{GenericOptionsParser}} as the Tool interface requires in
javadoc. That way, the {{-D key=value}} will be propagated to configuration; we can save the
required command parameter {{s3://BUCKET}} as value of the file system URI ({{-fs s3://BUCKET}})
will override the defaultFS from configuration file). Perhaps this has been discussed, or
a separate JIRA? I may have missed the major conclusion.

> Rethink S3GuardTool options
> ---------------------------
>
>                 Key: HADOOP-14094
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14094
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-14094-HADOOP-13345.001.patch, HADOOP-14094-HADOOP-13345.002.patch,
HADOOP-14094-HADOOP-13345.003.patch, HADOOP-14094-HADOOP-13345.003.patch, HADOOP-14094-HADOOP-13345.004.patch
>
>
> I think we need to rework the S3GuardTool options. A couple of problems I've observed
in the patches I've done on top of that and seeing other developers trying it out:
> * We should probably wrap the current commands in an S3Guard-specific command, since
'init', 'destroy', etc. don't touch the buckets at all.
> * Convert to whole-word options, as the single-letter options are already getting overloaded.
Some patches I've submitted have added functionality where the obvious flag is already in
use (e.g. -r for region, and read throughput, -m for minutes, and metadatastore uri).  I may
do this early as part of HADOOP-14090.
> * We have some options that must be in the config in some cases, and can be in the command
in other cases. But I've seen someone try to specify the table name in the config and leave
out the -m option, with no luck. Also, since commands hard-code table auto-creation, you might
have configured table auto-creation, try to import to a non-existent table, and it tells you
table auto-creation is off.
> We need a more consistent policy for how things should get configured that addresses
these problems and future-proofs the command a bit more.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message