hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14084) Shell.joinThread swallows InterruptedException
Date Thu, 23 Mar 2017 00:08:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937425#comment-15937425
] 

Mingliang Liu commented on HADOOP-14084:
----------------------------------------

I don't think {{joinThread()}} should simply throw InterruptedException immediately. We have
to observe the thread dies. Before returning, we can self interrupt.

> Shell.joinThread swallows InterruptedException
> ----------------------------------------------
>
>                 Key: HADOOP-14084
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14084
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Shixiong Zhu
>            Assignee: Xiaobing Zhou
>            Priority: Minor
>         Attachments: HADOOP-14084.000.patch
>
>
> In "Shell.joinThread", when the user tries to interrupt the thread that runs Shell.joinThread,
it will catch InterruptedException and propagate it to thread t. However, it doesn't set the
interrupt state of the current thread before returning, so the user codes won't know it's
already interrupted.
> See https://github.com/apache/hadoop/blob/9e19f758c1950cbcfcd1969461a8a910efca0767/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java#L1035



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message