hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vishwajeet Dusane (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14038) Rename ADLS credential properties
Date Mon, 13 Mar 2017 14:41:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907582#comment-15907582
] 

Vishwajeet Dusane commented on HADOOP-14038:
--------------------------------------------

{quote}
2. Maybe I miss something? TestValidateConfiguration does not seem to test deprecation at
all. It only forces... 
{quote}

Instead of retiring {{TestValidateConfiguration}}, we retain {{TestValidateConfiguration}}
to ensure keys defined in {{AdlConfKeys}} are not mistakenly modified. Also i am proposing
extend test in {{TestValidateConfiguration}} for backward compatibility check.

Example : 

{code}
@Test		
 public void validateConfigurationKeys() {
...
}

@Test		
 public void validateBackwardCompitibility() {
       // Verify for static & dynamic keys as well.
       Configuration conf = new Configuration();
       conf.add("dfs.adls.oauth2.client.id","XYZ");
       Assert.assertEquals("XYZ", conf.get(AZURE_AD_CLIENT_ID_KEY));
}

{code}

I am aware of few client who are consuming dynamic properties at the moment so being extra
cautious on not breaking them.

> Rename ADLS credential properties
> ---------------------------------
>
>                 Key: HADOOP-14038
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14038
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/adl
>    Affects Versions: 3.0.0-alpha3
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>         Attachments: HADOOP-14038.001.patch, HADOOP-14038.002.patch, HADOOP-14038.003.patch,
HADOOP-14038.004.patch, HADOOP-14038.005.patch, HADOOP-14038.006.patch
>
>
> Add ADLS credential configuration properties to {{core-default.xml}}. Set/document the
default value for {{dfs.adls.oauth2.access.token.provider.type}} to {{ClientCredential}}.
> Fix {{AdlFileSystem#getAccessTokenProvider}} which implies the provider type is {{Custom}}.
> Fix several unit tests that set {{dfs.adls.oauth2.access.token.provider}} but does not
set {{dfs.adls.oauth2.access.token.provider.type}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message