hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11095) How about Null check when closing inputstream object in JavaKeyStoreProvider#() ?
Date Tue, 28 Mar 2017 23:11:42 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946150#comment-15946150
] 

Hadoop QA commented on HADOOP-11095:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  7s{color} | {color:red}
HADOOP-11095 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-11095 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12669043/HADOOP-11095_001.patch
|
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/11957/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> How about Null check when closing inputstream object in JavaKeyStoreProvider#() ?
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-11095
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11095
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.5.1
>            Reporter: skrho
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-11095_001.patch
>
>
> In the finally block:
>           InputStream is = pwdFile.openStream();
>           try {
>             password = IOUtils.toCharArray(is);
>           } finally {
>             is.close();
>           }
>           
> How about Null check when closing inputstream object?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message