Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 27 Feb 2017 14:25:45 +0000 (UTC)
From: "Steve Loughran (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13046648.1488204971000.6328.1488205545335@Atlassian.JIRA>
In-Reply-To: <JIRA.13046648.1488204971000@Atlassian.JIRA>
References: <JIRA.13046648.1488204971000@Atlassian.JIRA> <JIRA.13046648.1488204971734@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HADOOP-14125) s3guard tool tests aren't isolated;
 can't run in parallel
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 27 Feb 2017 14:25:55 -0000


     [ https://issues.apache.org/jira/browse/HADOOP-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Loughran updated HADOOP-14125:
------------------------------------
    Description: 
The {{S3GuardToolTestBase}} don't parallelize and break other tests. This can surface if you do a full run with -Ds3guard and -Ddynamo.

# many of the test paths they create are being requested with absolute paths, e.g {{"/test-diff"}}.
# the base class doesn't  set up a per-forked-JUnit-test runner path in the bucket
# and there's no cleanup at the end of each test case; teardown() is empty.

Ideally, the tests should be made child classes of  {{AbstractS3ATestBase}}, with its post-run cleanup, If that can't be done, then the tests must 
# use {{S3ATestUtils.createTestPath(super.getTestPath())}} to create the base test path
# clean up that dir in teardown if the FS instance is non-null. {{ContractTestUtils.cleanup()}} can do this.

If it happens that the tests cannot run in parallel with others, then the build must be changed to exclude them from the parallel test run phase & include them in the serialized section.

  was:
The {{S3GuardToolTestBase}} don't parallelize and break other tests. This can surface if you do a full run with -Ds3guard and -Ddynamo.

# many of the test paths they create are being requested with absolute paths, e.g {{"/test-diff"}}.
# the base class doesn't  set up a per-forked-JUnit-test runner path in the bucket
# and there's no cleanup at the end of each test case; teardown() is empty.

Ideally, the tests should be made child classes of  {{AbstractS3ATestBase}}, with its post-run cleanup, If that can't be done, then the tests must 
# use {{S3ATestUtils.createTestPath(super.getTestPath())} to create the base test path
# clean up that dir in teardown if the FS instance is non-null. {{ContractTestUtils.cleanup()}} can do this.

If it happens that the tests cannot run in parallel with others, then the build must be changed to exclude them from the parallel test run phase & include them in the serialized section.


> s3guard tool tests aren't isolated; can't run in parallel
> ---------------------------------------------------------
>
>                 Key: HADOOP-14125
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14125
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3, test
>    Affects Versions: HADOOP-13345
>            Reporter: Steve Loughran
>            Assignee: Sean Mackrory
>
> The {{S3GuardToolTestBase}} don't parallelize and break other tests. This can surface if you do a full run with -Ds3guard and -Ddynamo.
> # many of the test paths they create are being requested with absolute paths, e.g {{"/test-diff"}}.
> # the base class doesn't  set up a per-forked-JUnit-test runner path in the bucket
> # and there's no cleanup at the end of each test case; teardown() is empty.
> Ideally, the tests should be made child classes of  {{AbstractS3ATestBase}}, with its post-run cleanup, If that can't be done, then the tests must 
> # use {{S3ATestUtils.createTestPath(super.getTestPath())}} to create the base test path
> # clean up that dir in teardown if the FS instance is non-null. {{ContractTestUtils.cleanup()}} can do this.
> If it happens that the tests cannot run in parallel with others, then the build must be changed to exclude them from the parallel test run phase & include them in the serialized section.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org