Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6694A200C25 for ; Fri, 24 Feb 2017 12:12:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 651E4160B69; Fri, 24 Feb 2017 11:12:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AFD17160B5C for ; Fri, 24 Feb 2017 12:12:55 +0100 (CET) Received: (qmail 1025 invoked by uid 500); 24 Feb 2017 11:12:54 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 1014 invoked by uid 99); 24 Feb 2017 11:12:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2017 11:12:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 40B0DC1362 for ; Fri, 24 Feb 2017 11:12:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -2.347 X-Spam-Level: X-Spam-Status: No, score=-2.347 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-2.999, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3PK60gf4wLQM for ; Fri, 24 Feb 2017 11:12:53 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D386D5F56F for ; Fri, 24 Feb 2017 11:12:52 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C464EE08B8 for ; Fri, 24 Feb 2017 11:12:44 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3A73024138 for ; Fri, 24 Feb 2017 11:12:44 +0000 (UTC) Date: Fri, 24 Feb 2017 11:12:44 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-14114) S3A can no longer handle unencoded + in URIs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 24 Feb 2017 11:12:56 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882465#comment-15882465 ] Hudson commented on HADOOP-14114: --------------------------------- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11298 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11298/]) HADOOP-14114 S3A can no longer handle unencoded + in URIs. Contributed (stevel: rev 9c22a91662af24569191ce45289ef8266e8755cc) * (edit) hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3native/TestS3xLoginHelper.java * (edit) hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3native/S3xLoginHelper.java > S3A can no longer handle unencoded + in URIs > --------------------------------------------- > > Key: HADOOP-14114 > URL: https://issues.apache.org/jira/browse/HADOOP-14114 > Project: Hadoop Common > Issue Type: Bug > Components: fs/s3 > Affects Versions: 2.8.0 > Reporter: Sean Mackrory > Assignee: Sean Mackrory > Priority: Minor > Fix For: 2.8.1 > > Attachments: HADOOP-14114.001.patch > > > Amazon secret access keys can include alphanumeric characters, but also / and + (I wish there was an official source that was really specific on what they can contain, but I'll have to rely on a few blog posts and my own experience). > Keys containing slashes used to be impossible to embed in the URL (e.g. s3a://access_key:secret_key@bucket/) but it is now possible to do it via URL encoding. Pluses used to work, but that is now *only* possible via URL encoding. > In the case of pluses, they don't appear to cause any other problems for parsing. So IMO the best all-around solution here is for people to URL-encode these keys always, but so that keys that used to work just fine can continue to work fine, all we need to do is detect that, log a warning, and we can re-encode it for the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org