Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 48872200C1C for ; Wed, 15 Feb 2017 23:54:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4714B160B70; Wed, 15 Feb 2017 22:54:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8D7C7160B4D for ; Wed, 15 Feb 2017 23:54:47 +0100 (CET) Received: (qmail 3356 invoked by uid 500); 15 Feb 2017 22:54:46 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 3344 invoked by uid 99); 15 Feb 2017 22:54:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Feb 2017 22:54:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4739AC010F for ; Wed, 15 Feb 2017 22:54:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 9EToXl1HJYP8 for ; Wed, 15 Feb 2017 22:54:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 33F2D5F19B for ; Wed, 15 Feb 2017 22:54:45 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9D486E078B for ; Wed, 15 Feb 2017 22:54:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id EA3D22412B for ; Wed, 15 Feb 2017 22:54:41 +0000 (UTC) Date: Wed, 15 Feb 2017 22:54:41 +0000 (UTC) From: "Mingliang Liu (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-14085) Drop unnecessary type assertion and cast MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 15 Feb 2017 22:54:48 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HADOOP-14085: ----------------------------------- Target Version/s: HADOOP-13345 +1 Specially, after [HADOOP-13914], we could all use plain FileStatus before [HADOOP-13736] has good reason to go. > Drop unnecessary type assertion and cast > ---------------------------------------- > > Key: HADOOP-14085 > URL: https://issues.apache.org/jira/browse/HADOOP-14085 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Reporter: Sean Mackrory > Assignee: Sean Mackrory > Attachments: HADOOP-14085-HADOOP-13345.001.patch > > > This is a spin-off from some discussion on HADOOP-13736. There's an assertion and type-cast that often causes a large number of test failures (this can be seen at HADOOP-14041). It appears to be unnecessary - things work really well by just removing that, and unless there's a good reason or test of something S3-specific, we should handle FileStatus in metadata anyway. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org