Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 1 Feb 2017 14:01:52 +0000 (UTC)
From: "Steve Loughran (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13038288.1485468956000.8000.1485957712016@Atlassian.JIRA>
In-Reply-To: <JIRA.13038288.1485468956000@Atlassian.JIRA>
References: <JIRA.13038288.1485468956000@Atlassian.JIRA> <JIRA.13038288.1485468956516@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HADOOP-14028) S3A block output streams don't
 delete temporary files in multipart uploads
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 01 Feb 2017 14:01:59 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-14028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848395#comment-15848395 ] 

Steve Loughran commented on HADOOP-14028:
-----------------------------------------

..looking into {{com.amazonaws.services.s3.model.S3DataSource}}, the cleanup code call at the end of the multipart put doesn't 

{code}
// restore the original input stream so the caller could close                   
// it if necessary                                                               
req.setInputStream(inputStreamOrig);                                             
req.setFile(fileOrig);                                                           
{code}

Conclusion: uploadPart really doesn't close input streams, we need to do it ourselves. As putObject *does*, I'm going to leave it alone, and rely on our new tests to pick up regressions in future

> S3A block output streams don't delete temporary files in multipart uploads
> --------------------------------------------------------------------------
>
>                 Key: HADOOP-14028
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14028
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 3.0.0-alpha2
>         Environment: JDK 8 + ORC 1.3.0 + hadoop-aws 3.0.0-alpha2
>            Reporter: Seth Fitzsimmons
>            Assignee: Steve Loughran
>         Attachments: HADOOP-14028-branch-2-001.patch
>
>
> I have `fs.s3a.fast.upload` enabled with 3.0.0-alpha2 (it's exactly what I was looking for after running into the same OOM problems) and don't see it cleaning up the disk-cached blocks.
> I'm generating a ~50GB file on an instance with ~6GB free when the process starts. My expectation is that local copies of the blocks would be deleted after those parts finish uploading, but I'm seeing more than 15 blocks in /tmp (and none of them have been deleted thus far).
> I see that DiskBlock deletes temporary files when closed, but is it closed after individual blocks have finished uploading or when the entire file has been fully written to the FS (full upload completed, including all parts)?
> As a temporary workaround to avoid running out of space, I'm listing files, sorting by atime, and deleting anything older than the first 20: `ls -ut | tail -n +21 | xargs rm`
> Steve Loughran says:
> > They should be deleted as soon as the upload completes; the close() call that the AWS httpclient makes on the input stream triggers the deletion. Though there aren't tests for it, as I recall.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org