hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-14130) Simplify DynamoDBClientFactory for creating Amazon DynamoDB clients
Date Tue, 28 Feb 2017 05:51:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887310#comment-15887310
] 

Mingliang Liu edited comment on HADOOP-14130 at 2/28/17 5:50 AM:
-----------------------------------------------------------------

For v0 patch, I tested against us-west-2 using {{cmvn -Dit.test='ITestS3A*' -Dtest=none -Dscale
-Ds3guard -Ddynamo -q clean verify}}. Will test again as there might be changes per review.
{{S3GuardTool}} is definitely broken with this change, but the fix should not be complex.
I'll work on that with incoming patches.


was (Author: liuml07):
For v1 patch, I tested against us-west-2 using {{cmvn -Dit.test='ITestS3A*' -Dtest=none -Dscale
-Ds3guard -Ddynamo -q clean verify}}. Will test again as there might be changes per review.
{{S3GuardTool}} is definitely broken with this change, but the fix should not be complex.
I'll work on that with incoming patches.

> Simplify DynamoDBClientFactory for creating Amazon DynamoDB clients
> -------------------------------------------------------------------
>
>                 Key: HADOOP-14130
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14130
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>         Attachments: HADOOP-14130-HADOOP-13345.000.patch, HADOOP-14130-HADOOP-13345.001.patch
>
>
> So, we are using deprecated {{AmazonDynamoDBClient}} class to create a DynamoDB client
instead of the recommended builder. We had discussion in [HADOOP-13345] for preferring region
to endpoints for user to specify the DynamoDB region (if associated S3 region is unknown or
different). We have reported inconsistent behavior if endpoint and S3 region are different
in [HADOOP-14027]. We also noticed that {{DynamoDBMetadataStore}} may sometimes logs nonsense
region. And in [HADOOP-13252], we also have feelings that file system URI is not needed to
create a {{AWSCredentialProvider}}. Resultantly we don't need to pass down file system URI
for creating a DynamoDB client.
> So this JIRA is to change this, best effort.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message