hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14125) s3guard tool tests aren't isolated; can't run in parallel
Date Tue, 28 Feb 2017 20:30:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888813#comment-15888813

Aaron Fabbri commented on HADOOP-14125:

+1 LGTM.

I will give it a test run when I get a chance, but feel free to commit this.

> s3guard tool tests aren't isolated; can't run in parallel
> ---------------------------------------------------------
>                 Key: HADOOP-14125
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14125
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3, test
>    Affects Versions: HADOOP-13345
>            Reporter: Steve Loughran
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-14125-HADOOP-13345.001.patch
> The {{S3GuardToolTestBase}} don't parallelize and break other tests. This can surface
if you do a full run with -Ds3guard and -Ddynamo.
> # many of the test paths they create are being requested with absolute paths, e.g {{"/test-diff"}}.
> # the base class doesn't  set up a per-forked-JUnit-test runner path in the bucket
> # and there's no cleanup at the end of each test case; teardown() is empty.
> Ideally, the tests should be made child classes of  {{AbstractS3ATestBase}}, with its
post-run cleanup, If that can't be done, then the tests must 
> # use {{S3ATestUtils.createTestPath(super.getTestPath())}} to create the base test path
> # clean up that dir in teardown if the FS instance is non-null. {{ContractTestUtils.cleanup()}}
can do this.
> If it happens that the tests cannot run in parallel with others, then the build must
be changed to exclude them from the parallel test run phase & include them in the serialized

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message