hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14096) s3guard: regression in dirListingUnion
Date Mon, 20 Feb 2017 05:18:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874049#comment-15874049
] 

Aaron Fabbri commented on HADOOP-14096:
---------------------------------------

[~mackrorysd] FYI.. I'm in the middle of some stuff so I'm not working up a patch + unit test
for this yet.  Will probably do it tomorrow if you don't beat me to it.

> s3guard: regression in dirListingUnion
> --------------------------------------
>
>                 Key: HADOOP-14096
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14096
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: HADOOP-13345
>            Reporter: Aaron Fabbri
>            Priority: Critical
>
> Just noticed HADOOP-14020 introduced a bug in S3Guard#dirListingUnion.
> The offending change is here:
> {noformat}
> -      if (dirMeta.get(s.getPath()) == null) {
> -        dirMeta.put(s);
> -      }
> +      changed = changed || dirMeta.put(s);
> +    }
> +
> {noformat}
> hint: Logical OR is a short-circuit operator.
>   Easy fix, but should probably come with a unit test for dirListingUnion().



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message