hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14068) Add integration test version of TestMetadataStore for DynamoDB
Date Tue, 21 Feb 2017 22:38:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876895#comment-15876895
] 

Aaron Fabbri commented on HADOOP-14068:
---------------------------------------

Looks good for the most part.. two things:

- Where did ITestDynamoDBMetadataStore.java go?
- I suggested resetting the interrupt flag on the thread following InterruptedException, but
I think the codebase consistently just rethrows InterruptedIOException.  We should follow
that behavior IMO.  e.g.:

{noformat}
    } catch (InterruptedException e) {
      LOG.error("Interrupted while reprovisioning I/O for table; " +
          "may not have taken effect yet...");
      throw new InterruptedIOException(""Interrupted while reprovisioning I/O for table");
    }
{noformat}

> Add integration test version of TestMetadataStore for DynamoDB
> --------------------------------------------------------------
>
>                 Key: HADOOP-14068
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14068
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-14068-HADOOP-13345.001.patch, HADOOP-14068-HADOOP-13345.002.patch,
HADOOP-14068-HADOOP-13345.003.patch
>
>
> I tweaked TestDynamoDBMetadataStore to run against the actual Amazon DynamoDB service
(as opposed to the "local" edition). Several tests failed because of minor variations in behavior.
I think the differences that are clearly possible are enough to warrant extending that class
as an ITest (but obviously keeping the existing test so 99% of the the coverage remains even
when not configured for actual DynamoDB usage).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message