hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14065) AliyunOSS: oss directory filestatus should use meta time
Date Thu, 09 Feb 2017 04:58:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859024#comment-15859024
] 

Kai Zheng commented on HADOOP-14065:
------------------------------------

Thanks Hui and Genmao on this. It looks a good catch. Comments:
* Would you help polish the JIRA description to make it better? 
* In the new test for the fix, it may be good enough to verify {{dirFileStatus.getModificationTime()
> 0}}. The assertion of {{currentTime - dirFileStatus.getModificationTime() < 5000L}}
could be broken easily if the system time isn't synced with the cloud machine. 

> AliyunOSS: oss directory filestatus should use meta time
> --------------------------------------------------------
>
>                 Key: HADOOP-14065
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14065
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/oss
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Fei Hui
>            Assignee: Fei Hui
>         Attachments: HADOOP-14065.001.patch, HADOOP-14065.002.patch, HADOOP-14065.003.patch,
HADOOP-14065.patch
>
>
> code in getFileStatus function
> else if (objectRepresentsDirectory(key, meta.getContentLength())) {
>   return new FileStatus(0, true, 1, 0, 0, qualifiedPath);
> }
> we should set right modifiedtime



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message