hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14058) Fix NativeS3FileSystemContractBaseTest#testDirWithDifferentMarkersWorks
Date Thu, 09 Feb 2017 14:13:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859569#comment-15859569
] 

Steve Loughran commented on HADOOP-14058:
-----------------------------------------

no need to declare a branch; if it's against trunk you can skip a suffix, if it's branch-2
then use -branch-2 as the suffix

what is important is that you need to confirm that you've tested against an object store:
the way we do this is require that the patch submitter says which s3 endpoint they ran their
tests against. 

> Fix NativeS3FileSystemContractBaseTest#testDirWithDifferentMarkersWorks
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-14058
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14058
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3, test
>            Reporter: Akira Ajisaka
>            Assignee: Yiqun Lin
>              Labels: s3
>         Attachments: HADOOP-14058.001.patch, HADOOP-14058-HADOOP-13345.001.patch
>
>
> In NativeS3FileSystemContractBaseTest#testDirWithDifferentMarkersWorks, 
> {code}
>       else if (i == 3) {
>         // test both markers
>         store.storeEmptyFile(base + "_$folder$");
>         store.storeEmptyFile(base + "/dir_$folder$");
>         store.storeEmptyFile(base + "/");
>         store.storeEmptyFile(base + "/dir/");
>       }
> {code}
> the above test code is not executed. In the following code:
> {code}
>     for (int i = 0; i < 3; i++) {
> {code}
> < should be <=.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message