hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vishwajeet Dusane (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14017) User friendly name for ADLS user and group
Date Tue, 21 Feb 2017 17:26:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876325#comment-15876325

Vishwajeet Dusane commented on HADOOP-14017:

Thanks for the comment [~jzhuge].

#190-192, #88: Consider “oidOrUpn = enableUPN ? UserGroupRepresentation.UPN : UserGroupRepresentation.OID;”
and remove the initializer at #88. What do you think?

Are you suggesting? 

private UserGroupRepresentation oidOrUpn;
oidOrUpn = enableUPN ? UserGroupRepresentation.UPN : UserGroupRepresentation.OID;

instead of 
private UserGroupRepresentation oidOrUpn = UserGroupRepresentation.OID;
if (enableUPN) {
   oidOrUpn = UserGroupRepresentation.UPN;

Document the default value is false for the sake of performance
Documentation is already there in patch 02 as 

            When false (default) : User and Group in FileStatus/AclStatus
            response is represented by the unique identifier from Azure AD
            profile (Object ID as GUID).

            For performance optimization, Recommended default value.

Please let me know if you had different suggestion? 

Mention that setOwner/setAcl accept both UPN and OID

Good point. Will mention in the {{Features}} section.

4. Performance impact depends upon the number of unique user from the retrieved list and if
explicit look up is required with Azure AD for name resolution.

> User friendly name for ADLS user and group
> ------------------------------------------
>                 Key: HADOOP-14017
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14017
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/adl
>    Affects Versions: 3.0.0-alpha3
>            Reporter: John Zhuge
>            Assignee: Vishwajeet Dusane
>         Attachments: HADOOP-14017.01.patch, HADOOP-14017.02.patch
> ADLS displays GUID whenever user or group displayed, e.g., {{ls}}, {{getfacl}}.
> ADLS requires GUID whenever user or group input is needed, e.g., {{setfacl}}, {{chown}}.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message