hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14017) User friendly name for ADLS user and group
Date Tue, 21 Feb 2017 16:40:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876264#comment-15876264
] 

John Zhuge commented on HADOOP-14017:
-------------------------------------

+1.  Rev 02 Looks great! Very few minor nitpicks:

AdlConfKeys
- #92: line wrap after “=“ ? This way, the entire string value is on 1 line.

AdlFileSystem
- #190-192, #88: Consider “oidOrUpn = enableUPN ? UserGroupRepresentation.UPN : UserGroupRepresentation.OID;”
and remove the initializer at #88. What do you think?

index.md
- #238-240:
    - Document the default value is false for the sake of performance
    - Mention that setOwner/setAcl accept both UPN and OID
    - Lower case getFileStatus/listStatus/getAclStatus

BTW, how much is the performance impact when UPN is on?


> User friendly name for ADLS user and group
> ------------------------------------------
>
>                 Key: HADOOP-14017
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14017
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/adl
>    Affects Versions: 3.0.0-alpha3
>            Reporter: John Zhuge
>            Assignee: Vishwajeet Dusane
>         Attachments: HADOOP-14017.01.patch, HADOOP-14017.02.patch
>
>
> ADLS displays GUID whenever user or group displayed, e.g., {{ls}}, {{getfacl}}.
> ADLS requires GUID whenever user or group input is needed, e.g., {{setfacl}}, {{chown}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message