hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-13994) explicitly declare the commons-lang3 dependency as 3.4
Date Thu, 23 Feb 2017 22:24:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15881411#comment-15881411
] 

Mingliang Liu edited comment on HADOOP-13994 at 2/23/17 10:24 PM:
------------------------------------------------------------------

Sorry [~stevel@apache.org] I missed this point when I did the merge from {{trunk}} to [HADOOP-13345]
feature branch. When I merged, I was still thinking that we didn't have to exclude this dependency
explicitly in DDBLocal. Then I realized that the AWS shaded uber jar does not include DDBLocal
package (which clearly has its own maven repository).

# Should we make this a subtask of [HADOOP-13345] Uber JIRA? Tracking there seems helpful
to me at least.
# Should we file a new JIRA to add this effort back (only need change in hadoop-tools/hadoop-aws/pom.xml
for DDBLocal exclusion tag), or re-open this and commit an addendum patch?

Thanks!


was (Author: liuml07):
Sorry [~stevel@apache.org] I missed this point when I did the merge from {{trunk}} to [HADOOP-13345]
feature branch. When I merged, I was still thinking that we didn't have to exclude this dependency
explicitly in DDBLocal. Then I realized that the AWS shaded uber jar does not include DDBLocal
package (which clearly has its own maven repository).

# Should we make this a subtask of [HADOOP-13345] Uber JIRA? Tracking there seems helpful
to me at least.
# Should we file a new JIRA to add this effort back (only in hadoop-tools/hadoop-aws/pom.xml
for DDBLocal exclusion tag), or re-open this and commit an addendum patch?

Thanks!

> explicitly declare the commons-lang3 dependency as 3.4
> ------------------------------------------------------
>
>                 Key: HADOOP-13994
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13994
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build, fs/azure, fs/s3
>    Affects Versions: 3.0.0-alpha2, HADOOP-13345
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>             Fix For: HADOOP-13345
>
>         Attachments: HADOOP-13994-HADOOP-13345-001.patch, HADOOP-13994-HADOOP-13445-001.patch
>
>
> Other people aren't seeing this (yet?), but unless you explicitly exclude v 3.4 of commons-lang3
from the azure build (which HADOOP-13660 does), then the dependency declaration of commons-lang3
v 3.3.2 is creating a resolution conflict. That's a dependency only needed for the local dynamodb
& tests.
> I propose to fix this in s3guard by explicitly declaring the version used in the tests
to be that of the azure-storage one, excluding that you get for free. It doesn't impact anything
shipped in production, but puts the hadoop build in control of what versions of commons-lang
are coming in everywhere by way of the commons-config version declared in hadoop-common



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message