hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13924) Update checkstyle and checkstyle plugin version to handle indentation of JDK8 Lambdas
Date Mon, 27 Feb 2017 07:52:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885301#comment-15885301
] 

Akira Ajisaka commented on HADOOP-13924:
----------------------------------------

Yetus checkstyle.sh is broken by the format change in checkstyle 6.14 (https://github.com/checkstyle/checkstyle/issues/2666).
Filed YETUS-489.

> Update checkstyle and checkstyle plugin version to handle indentation of JDK8 Lambdas
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13924
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13924
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Xiaoyu Yao
>            Assignee: Akira Ajisaka
>             Fix For: 3.0.0-alpha3
>
>         Attachments: HADOOP-13924.01.patch
>
>
> Have seen this lately form Jenkins run. Propose add the following to maven checkstyle
plugin configuration to better handle this. 
> {code}
> <dependency>
>   <groupId>com.puppycrawl.tools</groupId>
>   <artifactId>checkstyle</artifactId>
>   <version>7.3</version>
> </dependency>
> {code}
> {code}
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2049:
         if (failedVolumes.size() > 0) {: 'if' have incorrect indentation level 10, expected
level should be 8.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2050:
           LOG.warn("checkDiskErrorAsync callback got {} failed volumes: {}",: 'if' child
have incorrect indentation level 12, expected level should be 10.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2052:
         } else {: 'if rcurly' have incorrect indentation level 10, expected level should
be 8.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2053:
           LOG.debug("checkDiskErrorAsync: no volume failures detected");: 'else' child have
incorrect indentation level 12, expected level should be 10.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2054:
         }: 'else rcurly' have incorrect indentation level 10, expected level should be 8.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2055:
         lastDiskErrorCheck = Time.monotonicNow();: 'block' child have incorrect indentation
level 10, expected level should be 8.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2056:
         handleVolumeFailures(failedVolumes);: 'block' child have incorrect indentation level
10, expected level should be 8.
> ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java:2057:
       });: 'block rcurly' have incorrect indentation level 8, expected level should be 6.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message