hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13866) Upgrade netty-all to 4.1.1.Final
Date Tue, 28 Feb 2017 02:44:45 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887115#comment-15887115
] 

Andrew Wang commented on HADOOP-13866:
--------------------------------------

We don't need to debate whether this is source incompatible; the earlier versions of the patch
on this JIRA required source code updates until we reverted HDFS-8377.

I agree that it's unfortunate that downstream dependencies use our classpath, but it's a reality
of life and something we're responsible for maintaining. Previous Netty bumps have required
downstream changes because of the source incompatibilities, which is why I'm asking for extra
precautions before we bump this time.

Regarding shading, after a lot of discussion of alternatives on HADOOP-11656, we ended up
using shading to make isolated client artifacts. If you have preferred alternative means of
achieving classpath isolation besides shading, I'm open to pursuing those too.

> Upgrade netty-all to 4.1.1.Final
> --------------------------------
>
>                 Key: HADOOP-13866
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13866
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Blocker
>         Attachments: HADOOP-13866.v1.patch, HADOOP-13866.v2.patch, HADOOP-13866.v3.patch,
HADOOP-13866.v4.patch, HADOOP-13866.v6.patch, HADOOP-13866.v7.patch, HADOOP-13866.v8.patch,
HADOOP-13866.v8.patch, HADOOP-13866.v8.patch, HADOOP-13866.v9.patch
>
>
> netty-all 4.1.1.Final is stable release which we should upgrade to.
> See bottom of HADOOP-12927 for related discussion.
> This issue was discovered since hbase 2.0 uses 4.1.1.Final of netty.
> When launching mapreduce job from hbase, /grid/0/hadoop/yarn/local/  usercache/hbase/appcache/application_1479850535804_0008/container_e01_1479850535804_0008_01_000005/mr-framework/hadoop/share/hadoop/hdfs/lib/netty-all-4.0.23.Final.jar
(from hdfs) is ahead of 4.1.1.Final jar (from hbase) on the classpath.
> Resulting in the following exception:
> {code}
> 2016-12-01 20:17:26,678 WARN [Default-IPC-NioEventLoopGroup-1-1] io.netty.util.concurrent.DefaultPromise:
An exception was thrown by org.apache.hadoop.hbase.ipc.NettyRpcConnection$3.operationComplete()
> java.lang.NoSuchMethodError: io.netty.buffer.ByteBuf.retainedDuplicate()Lio/netty/buffer/ByteBuf;
>         at org.apache.hadoop.hbase.ipc.NettyRpcConnection$3.operationComplete(NettyRpcConnection.java:272)
>         at org.apache.hadoop.hbase.ipc.NettyRpcConnection$3.operationComplete(NettyRpcConnection.java:262)
>         at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:680)
>         at io.netty.util.concurrent.DefaultPromise.notifyListeners0(DefaultPromise.java:603)
>         at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:563)
>         at io.netty.util.concurrent.DefaultPromise.trySuccess(DefaultPromise.java:406)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message