hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13075) Add support for SSE-KMS and SSE-C in s3a filesystem
Date Thu, 02 Feb 2017 22:09:51 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15850588#comment-15850588
] 

ASF GitHub Bot commented on HADOOP-13075:
-----------------------------------------

Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/183#discussion_r99232624
  
    --- Diff: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java
---
    @@ -98,24 +101,26 @@
        */
       private long contentRangeStart;
     
    -  public S3AInputStream(String bucket,
    -      String key,
    -      long contentLength,
    -      AmazonS3 client,
    -      FileSystem.Statistics stats,
    -      S3AInstrumentation instrumentation,
    -      long readahead,
    -      S3AInputPolicy inputPolicy) {
    -    Preconditions.checkArgument(StringUtils.isNotEmpty(bucket), "No Bucket");
    -    Preconditions.checkArgument(StringUtils.isNotEmpty(key), "No Key");
    -    Preconditions.checkArgument(contentLength >= 0 , "Negative content length");
    -    this.bucket = bucket;
    -    this.key = key;
    +  public S3AInputStream(S3ObjectAttributes s3Attributes,
    +                        long contentLength,
    +                        AmazonS3 client,
    +                        FileSystem.Statistics stats,
    +                        S3AInstrumentation instrumentation,
    +                        long readahead,
    +                        S3AInputPolicy inputPolicy) {
    +    Preconditions.checkArgument(StringUtils.isNotEmpty(s3Attributes.getBucket()), "No
Bucket");
    --- End diff --
    
    I wouldn't adjust the indentation, because it amplifies the diff and makes merging harder.
Lines 105-110 should be the same as the original.


> Add support for SSE-KMS and SSE-C in s3a filesystem
> ---------------------------------------------------
>
>                 Key: HADOOP-13075
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13075
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Andrew Olson
>            Assignee: Steve Loughran
>
> S3 provides 3 types of server-side encryption [1],
> * SSE-S3 (Amazon S3-Managed Keys) [2]
> * SSE-KMS (AWS KMS-Managed Keys) [3]
> * SSE-C (Customer-Provided Keys) [4]
> Of which the S3AFileSystem in hadoop-aws only supports opting into SSE-S3 (HADOOP-10568)
-- the underlying aws-java-sdk makes that very simple [5]. With native support in aws-java-sdk
already available it should be fairly straightforward [6],[7] to support the other two types
of SSE with some additional fs.s3a configuration properties.
> [1] http://docs.aws.amazon.com/AmazonS3/latest/dev/serv-side-encryption.html
> [2] http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingServerSideEncryption.html
> [3] http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingKMSEncryption.html
> [4] http://docs.aws.amazon.com/AmazonS3/latest/dev/ServerSideEncryptionCustomerKeys.html
> [5] http://docs.aws.amazon.com/AmazonS3/latest/dev/SSEUsingJavaSDK.html
> [6] http://docs.aws.amazon.com/AmazonS3/latest/dev/kms-using-sdks.html#kms-using-sdks-java
> [7] http://docs.aws.amazon.com/AmazonS3/latest/dev/sse-c-using-java-sdk.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message