Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9AE23200BF4 for ; Fri, 6 Jan 2017 20:57:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9970C160B48; Fri, 6 Jan 2017 19:57:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 15F98160B39 for ; Fri, 6 Jan 2017 20:56:59 +0100 (CET) Received: (qmail 13094 invoked by uid 500); 6 Jan 2017 19:56:59 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 13041 invoked by uid 99); 6 Jan 2017 19:56:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jan 2017 19:56:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 017902C2ABB for ; Fri, 6 Jan 2017 19:56:59 +0000 (UTC) Date: Fri, 6 Jan 2017 19:56:59 +0000 (UTC) From: "Wei-Chiu Chuang (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-13953) Make FTPFileSystem's data connection mode and transfer mode configurable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 06 Jan 2017 19:57:00 -0000 [ https://issues.apache.org/jira/browse/HADOOP-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805557#comment-15805557 ] Wei-Chiu Chuang commented on HADOOP-13953: ------------------------------------------ Thanks [~xiaochen] for filing the bug report and contributing the patch. Overall looks good to me. Two nit: {code} LOG.info("Cannot parse the value for " + FS_FTP_DATA_CONNECTION_MODE + ": " + mode + ". Using default."); {code} Shouldn't it be a WARN log? It would also be nice to add the valid configuration values, and default values into core-default.xml > Make FTPFileSystem's data connection mode and transfer mode configurable > ------------------------------------------------------------------------ > > Key: HADOOP-13953 > URL: https://issues.apache.org/jira/browse/HADOOP-13953 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Affects Versions: 0.22.0 > Reporter: Xiao Chen > Assignee: Xiao Chen > Attachments: HADOOP-13953.01.patch, HADOOP-13953.02.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org