Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0AED3200C16 for ; Thu, 26 Jan 2017 02:21:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0969C160B5A; Thu, 26 Jan 2017 01:21:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 501B3160B4E for ; Thu, 26 Jan 2017 02:21:30 +0100 (CET) Received: (qmail 30858 invoked by uid 500); 26 Jan 2017 01:21:29 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 30847 invoked by uid 99); 26 Jan 2017 01:21:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2017 01:21:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D11201A04CF for ; Thu, 26 Jan 2017 01:21:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id luvWA_Yk7gJT for ; Thu, 26 Jan 2017 01:21:27 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 890365F3BF for ; Thu, 26 Jan 2017 01:21:27 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 13FBFE0416 for ; Thu, 26 Jan 2017 01:21:27 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 761A62528F for ; Thu, 26 Jan 2017 01:21:26 +0000 (UTC) Date: Thu, 26 Jan 2017 01:21:26 +0000 (UTC) From: "John Zhuge (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-13374) Add the L&N verification script MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 26 Jan 2017 01:21:31 -0000 [ https://issues.apache.org/jira/browse/HADOOP-13374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838965#comment-15838965 ] John Zhuge commented on HADOOP-13374: ------------------------------------- Patch 04 looks great. Thanks [~aw]! Here is the output for 3.0.0-alpha2-RC0: {noformat} $ bash dev-support/bin/verify-license-files ERROR: hadoop-client-api-3.0.0-alpha2.jar: Missing a LICENSE file ERROR: hadoop-client-api-3.0.0-alpha2.jar: No valid NOTICE found WARNING: hadoop-client-minicluster-3.0.0-alpha2.jar: Found 5 LICENSE files (0 were valid) ERROR: hadoop-client-minicluster-3.0.0-alpha2.jar: No valid LICENSE found WARNING: hadoop-client-minicluster-3.0.0-alpha2.jar: Found 3 NOTICE files (0 were valid) ERROR: hadoop-client-minicluster-3.0.0-alpha2.jar: No valid NOTICE found ERROR: hadoop-client-runtime-3.0.0-alpha2.jar: No valid LICENSE found ERROR: hadoop-client-runtime-3.0.0-alpha2.jar: No valid NOTICE found {noformat} As for [~xiaochen]'s suggestion on full path, how about this format: {noformat} $ bash dev-support/bin/verify-license-files hadoop-3.0.0-alpha2/share/hadoop/client/hadoop-client-api-3.0.0-alpha2.jar ERROR: Missing a LICENSE file ERROR: No valid NOTICE found hadoop-3.0.0-alpha2/share/hadoop/client/hadoop-client-minicluster-3.0.0-alpha2.jar WARNING: Found 5 LICENSE files (0 were valid) ERROR: No valid LICENSE found WARNING: Found 3 NOTICE files (0 were valid) ERROR: No valid NOTICE found hadoop-3.0.0-alpha2/share/hadoop/client/hadoop-client-runtime-3.0.0-alpha2.jar ERROR: No valid LICENSE found ERROR: No valid NOTICE found {noformat} > Add the L&N verification script > ------------------------------- > > Key: HADOOP-13374 > URL: https://issues.apache.org/jira/browse/HADOOP-13374 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Xiao Chen > Assignee: Allen Wittenauer > Attachments: HADOOP-13374.01.patch, HADOOP-13374.02.patch, HADOOP-13374.03.patch, HADOOP-13374.04.patch > > > This is the script that's used for L&N change verification during HADOOP-12893. We should commit this as [~ozawa] [suggested|https://issues.apache.org/jira/browse/HADOOP-13298?focusedCommentId=15374498&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15374498]. > I was [initially|https://issues.apache.org/jira/browse/HADOOP-12893?focusedCommentId=15283040&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15283040] verifying from an on-fly shell command, and [~andrew.wang] contributed the script later in [a comment| > https://issues.apache.org/jira/browse/HADOOP-12893?focusedCommentId=15303281&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15303281], so most credit should go to him. :) -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org