hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14020) Optimize dirListingUnion
Date Thu, 26 Jan 2017 22:13:24 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840550#comment-15840550
] 

Aaron Fabbri commented on HADOOP-14020:
---------------------------------------

Thanks! Besides the minor checkstyle issue...

{code}
       }
-      return S3Guard.dirListingUnion(metadataStore, path, result, dirMeta);
+      boolean isAuthoritative = getConf().getBoolean(
+          Constants.METADATASTORE_AUTHORITATIVE,
+          Constants.DEFAULT_METADATASTORE_AUTHORITATIVE);
+      return S3Guard.dirListingUnion(metadataStore, path, result, dirMeta,
+          isAuthoritative);
{code}

I think there is already a variable in S3AFileSystem with that value: allowAuthoritative.


> Optimize dirListingUnion
> ------------------------
>
>                 Key: HADOOP-14020
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14020
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-14020-HADOOP-13345.001.patch, HADOOP-14020-HADOOP-13345.002.patch,
HADOOP-14020-HADOOP-13345.003.patch
>
>
> There's a TODO in dirListingUnion:
> {quote}// TODO optimize for when allowAuthoritative = false{quote}
> There will be cases when we can intelligently avoid a round trip: if S3A results are
a subset or the metadatastore results (including them being equal or empty) then writing back
will do nothing (although perhaps that should set the authoritative flag if it isn't set already).
> There may also be cases where users want to just skip that altogether. It's wasted work
if authoritative mode is disabled, so perhaps we want to trigger a skip if that's false, or
perhaps it should be a separate property. First one makes for simpler config, second is more
flexible...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message