hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-14010) Fix the remaining shellcheck errors
Date Fri, 20 Jan 2017 22:58:26 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832562#comment-15832562
] 

Allen Wittenauer edited comment on HADOOP-14010 at 1/20/17 10:58 PM:
---------------------------------------------------------------------

There are lots and lots of small, minor fixes in -00.  But some aren't:
* create-release should check specific function failures before declaring a success. prior
it was doing something useless.
* remove dev-support/findHangingTest.sh.  it's super broken and nothing uses it.
* fix how verify-xml.sh exports vars for display later (they were reversed)
* test-libhdfs.sh got a major overhaul (including dropping support for Kaffe), but frankly,
it looks unusable since none of its dependencies appear to be actually in the build, and what
is there is in the wrong spot. Opened HDFS-11356.
* is killKdc.sh actually still used? Who knows. Rewrote it to use pkill where it can and something
more portable where it can't. (it used GNU-specific xargs before)
* distributed-excludes and refresh-namenodes still need their HADOOP-9902 followup. :(



was (Author: aw):
There are lots and lots of small, minor fixes in -00.  But some aren't:
* create-release should check specific function failures before declaring a success
* remove dev-support/findHangingTest.sh.  it's super broken and nothing uses it.
* fix how verify-xml.sh exports vars for display later (they were reversed)
* test-libhdfs.sh got a major overhaul (including dropping support for Kaffe), but frankly,
it looks unusable since none of its dependencies appear to be actually in the build, and what
is there is in the wrong spot. Opened HDFS-11356.
* is killKdc.sh actually still used? Who knows. Rewrote it to use pkill where it can and something
more portable where it can't. (it used GNU-specific xargs before)
* distributed-excludes and refresh-namenodes still need their HADOOP-9902 followup. :(
* 


> Fix the remaining shellcheck errors
> -----------------------------------
>
>                 Key: HADOOP-14010
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14010
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, scripts, test
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>
> There aren't that many left and many of them are new since the upgrade of shellcheck.
 Let's just knock them out.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message