hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13995) s3guard cli: make tests easier to run and address failure
Date Fri, 20 Jan 2017 11:30:26 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831568#comment-15831568
] 

Steve Loughran commented on HADOOP-13995:
-----------------------------------------

* All the tests are good to to me
* those checkstyle complaints do need to be addressed though

I'm in favour of automatically working out the endpoint from the bucket name, consistent with
how the code works today. if users want to work direct with endpoint and bucket, they should
have that right, in which case both arguments would be needed for table ops

Mixing s3a:// URL and -e? I'd rather not. If you really want to, you could set the fs.s3a.
 endpoint property —that way, you know what to set in the production code. Because if you
don't set it there, your bucket isn't going to work properly

> s3guard cli: make tests easier to run and address failure
> ---------------------------------------------------------
>
>                 Key: HADOOP-13995
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13995
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Aaron Fabbri
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-13995.001.patch, HADOOP-13995.002.patch, HADOOP-13995-HADOOP-13345.003.patch
>
>
> Following up on HADOOP-13650, we should:
> - Make it clearer which config parameters need to be set for test to succeed, and provide
good defaults.
> - Address any remaining test failures.
> - Change TestS3GuardTool to an ITest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message