hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei-Chiu Chuang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13953) Make FTPFileSystem's data connection mode and transfer mode configurable
Date Fri, 06 Jan 2017 19:56:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805557#comment-15805557
] 

Wei-Chiu Chuang commented on HADOOP-13953:
------------------------------------------

Thanks [~xiaochen] for filing the bug report and contributing the patch.
Overall looks good to me. Two nit:
{code}
LOG.info("Cannot parse the value for " + FS_FTP_DATA_CONNECTION_MODE
            + ": " + mode + ". Using default.");
{code}
Shouldn't it be a WARN log?

It would also be nice to add the valid configuration values, and default values into core-default.xml

> Make FTPFileSystem's data connection mode and transfer mode configurable
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-13953
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13953
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 0.22.0
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-13953.01.patch, HADOOP-13953.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message