hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13929) ADLS should not check in contract-test-options.xml
Date Fri, 06 Jan 2017 18:27:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805224#comment-15805224
] 

Chris Nauroth commented on HADOOP-13929:
----------------------------------------

I know John is making more changes, but here is my reply to the most recent comments.

Patch 005 deleted contract-test-options.xml, but kept it listed in .gitignore.  I don't think
it needs to remain in .gitignore, because there is no other file anywhere in the source tree
named contract-test-options.xml, besides the ADL one that the patch deletes.

In general though, trying to achieve some commonality across these file names and using .gitignore
entries that can cover all sub-modules globally sound like a great move for future-proofing
this.

bq. Another question: can we add another property fs.contract.test.enabled (default true to
be backwards compatible)?

I'm not sure I completely understand, but does the lack of fs in this new property mean that
it would be global, not tied to a specific file system's tests?  If it's global, then a weakness
of this approach is that for developers running {{mvn verify}} at the root of the source tree
or at the root of hadoop-cloud-storage-project, it would be all or nothing.  If a developer
had credentials to AWS and Azure but not OpenStack, then they'd need to do something different
to run just for the modules where they have credentials.

> ADLS should not check in contract-test-options.xml
> --------------------------------------------------
>
>                 Key: HADOOP-13929
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13929
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/adl, test
>    Affects Versions: 3.0.0-alpha2
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HADOOP-13929.001.patch, HADOOP-13929.002.patch, HADOOP-13929.003.patch,
HADOOP-13929.004.patch, HADOOP-13929.005.patch
>
>
> Should not check in the file {{contract-test-options.xml}}. Make sure the file is excluded
by {{.gitignore}}. Make sure ADLS {{index.md}} provides a complete example of this file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message