hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13885) Implement getLinkTarget for ViewFileSystem
Date Fri, 06 Jan 2017 21:40:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805841#comment-15805841
] 

Andrew Wang commented on HADOOP-13885:
--------------------------------------

Hi Manoj,

bq. I was following the getFileStatus() to model, to qualify returned paths. Let me know if
this raw target filesystem resolved path is ok and no more viewfs qualification is needed.

I'm pretty sure link targets are supposed to be returned as is, per the FileContext documentation.
It's similar to {{man 2 readlink}}, which returns the contents directly.

bq. In the attached patch v01, try block surrounds both Case 1 and Case 2 together. I will
fix this in the next patch revision so that only Case 1 returns NotInMountPointException and
Case 2 returns FNFE.

SGTM! Are there other places too where this should be changed?

> Implement getLinkTarget for ViewFileSystem
> ------------------------------------------
>
>                 Key: HADOOP-13885
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13885
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: viewfs
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Manoj Govindassamy
>            Assignee: Manoj Govindassamy
>         Attachments: HADOOP-13885.01.patch
>
>
> ViewFileSystem doesn't override FileSystem#getLinkTarget(). So, when view filesystem
is used to resolve the symbolic links, the default FileSystem implementation throws UnsupportedOperationException.
> The proposal is to define getLinkTarget() for ViewFileSystem and invoke the target FileSystem
for resolving the symbolic links. Path thus returned is preferred to be a viewfs qualified
path, so that it can be used again on the ViewFileSystem handle. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message